Skip to content

feat: platform secrets as sealed secrets#932

Merged
ferruhcihan merged 36 commits intomainfrom
APL-523
Apr 16, 2026
Merged

feat: platform secrets as sealed secrets#932
ferruhcihan merged 36 commits intomainfrom
APL-523

Conversation

@ferruhcihan
Copy link
Copy Markdown
Collaborator

@ferruhcihan ferruhcihan commented Feb 24, 2026

📌 Summary

PRs: apl-core | apl-tasks | apl-console

Comment thread src/otomi-stack.ts Fixed
Comment thread src/otomi-stack.ts Fixed
@ferruhcihan ferruhcihan marked this pull request as ready for review March 9, 2026 10:17
Copy link
Copy Markdown
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also really good improvmenets in here. I didn't saw any changes for the settings. Is that correct? I don't know from the top of my mind if we can change any secret values in the settings.

Comment thread src/utils/sealedSecretUtils.ts Outdated
Comment thread src/otomi-stack.ts Outdated
Comment thread src/otomi-stack.ts Outdated
Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.ts Outdated
Copy link
Copy Markdown
Contributor

@CasLubbers CasLubbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nice to have changes to make the code more readable. Rest looks good to me

Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.ts Outdated
Comment thread src/otomi-stack.ts
Comment thread src/otomi-stack.ts Outdated
@ferruhcihan ferruhcihan merged commit 6a22f1f into main Apr 16, 2026
8 of 9 checks passed
@ferruhcihan ferruhcihan deleted the APL-523 branch April 16, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants